Skip to content

Bugfix/FOUR-9761: AI> The History is cleared before save the process#5100

Merged
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-9761
Aug 7, 2023
Merged

Bugfix/FOUR-9761: AI> The History is cleared before save the process#5100
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-9761

Conversation

@agustinbusso
Copy link
Copy Markdown
Contributor

@agustinbusso agustinbusso commented Aug 4, 2023

Issue & Reproduction Steps

Steps to Reproduce

  • Have a process with some name: example "My Process"
  • Create a process IN AI
  • Click on USE MODEL button
  • In the process name recommended use the same name as the existing process: "My Process"
  • Click on save

Current Behavior
The history is cleared before creating the process if the process already exists in process table

Expected Behavior
The history should not be cleared if the process name is already taken. Only when the process is created should clear the history.

Solution

  • Emit history clear after the process is created

Working video

Screen.Recording.2023-08-04.at.17.29.54.mov

How to Test

  • Follow steps above.
  • First try with an existing process name, and the history should not be removed
  • Then try with a non existing process name, and the history should be removed
  • Verify the history was removed after the process was created.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@eiresendez eiresendez self-requested a review August 7, 2023 17:07
@ryancooley ryancooley merged commit 0a19d18 into develop Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants